relaton / relaton-nist

NistBib: retrieve NIST Standards for bibliographic use using the BibliographicItem model
https://www.metanorma.com
MIT License
2 stars 1 forks source link

(URGENT) Broken data for CSWP #75

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

From @strogonoff at https://github.com/ietf-ribose/bibxml-service/issues/134#issuecomment-1165234822

CSWPs are named by identifiers, not sequential IDs.

CSWP identifiers are possibly wrong.

For example, NIST CSWP 02122014—https://github.com/relaton/relaton-data-nist/tree/main/data/NIST_CSWP_02122014.yaml doesn’t exist, but we have https://github.com/relaton/relaton-data-nist/blob/b7042a5293b203037be1ca11ced9fbf5aa2a71cf/data/NIST_CSWP_1.yaml that has an external link to 02122014 (?).

Got errors for other CSWP identifiers, too (NIST CSWP 01262018, NIST CSWP 06032014, etc.).

andrew2net commented 2 years ago

@ronaldtse in the dataset https://raw.githubusercontent.com/usnistgov/NIST-Tech-Pubs/nist-pages/xml/allrecords.xml the documents with the external links have identifiers NIST CSWP 1, NIST CSWP 5, NIST CSWP 3, etc. Should we replace numbers in all the NIST CSWP * identifiers with numbers from the DOI external links?

ronaldtse commented 2 years ago

Oh my -- NIST has implemented the fix we suggested! All CSWPs now are numbered sequentially.

@andrew2net and @strogonoff, so this the correct data now. Look at CSWP 1, the DOI is CSWP.1. This is definitely intentional.

So we will need to map the CSWPs from the old identifiers to the new ones.

andrew2net commented 2 years ago

@ronaldtse should we implement an index to map the old identifiers?

ronaldtse commented 2 years ago

@andrew2net no, we just stay with the new identifiers. If the authoritative data source has updated identifiers, we only use those.

andrew2net commented 2 years ago

@ronaldtse so, can we close this issue?

ronaldtse commented 2 years ago

Closed.