search

remicorne / phd

Other
0 stars 1 forks source link

justStats() buggy #33

Closed jjb-hub closed 1 year ago

jjb-hub commented 1 year ago

issues

duplicating rows not updating them #REAL issue easy fix

saving tukey - p_value cols are a bit odd for this test as its between all groups for experiment - not sure how to improve but improvement need can close issue without

remicorne commented 1 year ago

https://github.com/jjb-hub/phd/pull/37

jjb-hub commented 1 year ago

ADDITIONALLY: In quantitativeSummary(), I use :
quant_stats_df = subselectDf(getQuantitativeStats(filename), {'experiment':experiment, 'compound':compound, 'region': region, 'test':test })

the issue here is that if I have not run juststats() for the same regions and compound then it has nothing in the df / alternatively if I run just stats within the function it will continue to duplicate the stats in the df

jjb-hub commented 1 year ago

JUST DUPLICATION ISSUE TO BE SOLVED PLS

re tukey i just unpack the 'result' column its great : histograms.py line 159