search

reneviering / vanilla-ui-router

Simple vanilla JavaScript router
MIT License
48 stars 5 forks source link

No Type Definitions #11

Open ebi-igweze opened 7 years ago

ebi-igweze commented 7 years ago

I've searched for type definitions both on npm and tsd but can't find. Are there any type definitions for vanilla-ui-router?

reneviering commented 7 years ago

Hey, thanks for trying vanilla-ui-router. This project is written in pure vanilla ES6 JavaScript to stay as simple as possible. So there are no type definitions in JavaScript. Feel free to fork this project.

René

reneviering commented 7 years ago

@nicolaisueper added some type definitions in his pull request https://github.com/micromata/vanilla-ui-router/pull/12/files. To separate the vanilla-ui-router ES6 code base from the type definitions it would be a good fit to put them to DefinitlyTyped.

I'm not a typescript pro, so pull requests are very welcome. Otherwise maybe I find the time to add it in the near future.

nicolaisueper commented 7 years ago

I'll do this until sunday ^^