search

resource-reasoning / jscert_dev

This repository is now abandoned in favour of using
https://github.com/jscert/jscert
Other
0 stars 0 forks source link

Prelude Loader violates 10.1.1 and user-functions may be hoisted above prelude #9

Open IgnoredAmbience opened 9 years ago

IgnoredAmbience commented 9 years ago

Concatenation of separate JS programs into one Program means that we do not use the correct strictness for them all if they differ. We should read each Program in separately.

Additionally, prelude functions, such as those used by conrad for his global object setup may be shadowed by user-code functions that are hoisted above them.

https://github.com/resource-reasoning/jscert_dev/blob/8e82674f794a116cc58d72dcc7f1faa84f373e7a/interp/src/run_js.ml#L87 https://es5.github.io/#x10.1.1

IgnoredAmbience commented 9 years ago

I think this is causing the failure of ch10/10.4/10.4.3/10.4.3-1-17gs.js

IgnoredAmbience commented 9 years ago

and tests/test262/ch10/10.4/10.4.3/10.4.3-1-19gs.js

IgnoredAmbience commented 9 years ago

Can confirm the commit on this ticket hasn't fixed the listed test cases.