Open baconcheeseburger opened 8 years ago
I've verified that this plugin works fine on 2.2.
ping @coffeemug it looks like a server crash
@deontologician -- are you subscribing to an artificial changefeed with squash
set to true
anywhere?
It looks like that's probably what's causing it (or at least I can make the server produce this error by doing that).
@deontologician -- the plugin should probably not be passing squash: true
when subscribing to artificial changefeeds. (I mean, the server should be failing gracefully rather than returning this error, but I would guess the old behavior was to just silently ignore the problem, and we might well patch it to produce a good error instead of this bad error.)
@baconcheeseburger -- you should be able to work around this by configuring the plugin to use squash: false
.
So if someone wants to throttle changes from the system tables, is there a better option than squash?
I don't think so. (Honestly this is a little bit of a weird convention, because my understanding is that unsquashed changes from system tables behave more like squashed changes from normal tables than unsquashed changes from normal tables. @VeXocide, do you know any more?)
Actually, nevermind @deontologician, I think we should continue having the behavior where we ignore the squash
flag for artificial changefeeds rather than erroring when it's set to true
.
I know the artificial changefeeds have some sample rate, can we just forward squash
to modify that?
Currently we have a global sampling that's shared across feeds. We could theoretically set the rate of that sampling to the smallest sample rate that's specified by any changefeed using squash
; that might be worth opening an issue for.
Updating rethinkdb causes the following error to be thrown: