search

rethinkdb / logstash-input-rethinkdb

Other
55 stars 13 forks source link

Add rethinkdb credentials option #20

Closed sagivf closed 7 years ago

sagivf commented 7 years ago

Adding the config options for rethinkdb user accounts

sagivf commented 7 years ago

I haven't tested this locally since i'm not sure how to (I might try again later). The changes seem pretty straight forward so i'm happy to test this against my staging environment once a new version number is released.

AtnNn commented 7 years ago

These changes LGTM, but I haven't tested them.

@sagivf Do they work with and without the new options?

sagivf commented 7 years ago

@AtnNn Yes, once we deploy this I will verify that it still works and then I will add the credential and verify that that works.

It needs to be published as logstash plugin. Have you found out how to do that?

wayann commented 7 years ago

hmmm, 25 days for a pull request... that's not very encouraging sign... @sagivf @AtnNn Since I badly need this plugin for my work, I've tested it on my "copy paste" hack https://github.com/wayann/logstash-input-rethinker I've forked the logstash-input-example and merged this plugin, so I've a logstash input rethinkdb plugin functional with latest logstash 5.x on my local machine.

if current maintainer want I'd happily pull in here the changes...

sagivf commented 7 years ago

@wayann wow, thanks for the hard work! @AtnNn It looks like this is indeed an important project. I've been using this for a while to sync the data in it works great 👍 I've mainly been waiting for this update so I can better secure my cluster, but moving to Elastic 5.x is defiantly on the roadmap.

@wayann Any chance you want to become a maintainer?

I will test your plugin soon. Any idea if this will work with Elasticsearch 2.x?

wayann commented 7 years ago

@sagivf why not... ain't tested it with elasticsearch 2.x

sagivf commented 7 years ago

@wayann Ive set up an two cluster: elastic 2.4 and 5.2.2.

1) I was only able to compile the ruby stuff with logstash 5.2.2

2) I was able to get the output to codec => json_lines

3) It failed on both, I hope you can assist me - opened an issue: https://github.com/wayann/logstash-input-rethinker/issues/2

4) My suggestion: if it fails on 2.4 lets make your repo the go to repo and make this repo and keep this one for those needing 2.4. @AtnNn could we move this under the rethinkdb github? (if that's ok with you @wayann of course)

5) If it works on 2.4 lets merge into here.

6) once we get 3,4,5 out the way. We should add this to the official logstash plugins, it's hard to get all the installs working (i'm using docker which makes it even harder).

7) we need to improve the docs, I can help with that.

Thanks guys. This is a super important and useful plugin (and I think it's not to complicated to maintain), so I hope we can bring it back to life...

wayann commented 7 years ago

@AtnNn @sagivf for me is ok

sagivf commented 7 years ago

@wayann apparently composte.io doesn't have elasticsearch5.x yet. I created one on elastic and it worked 😄 😄

So @AtnNn It would really help me out if: 1) We could we merge this pull request? 2) We could we get this deployed? (I think it's something to do with logstash-input-rethinkdb.gemspec

3) Not for me, but for others lets pull @wayann project into the rethinkdb umbrella, make it official for elasticsearch5.x, fix up it's docs and deploy it as well.

sagivf commented 7 years ago

@AtnNn Is this relevant for you, is there someone else that can help?

calvinbrewer commented 7 years ago

Merged and confirmed working with: logstash 2.3.4 elasticsearch 2.4.4

Would love for this to be merged!

sagivf commented 7 years ago

Thanks @AtnNn 👍 Please let use know once you have the credentials and this is release