search

retrospect-addon / plugin.video.retrospect

Retrospect is a Kodi video add-on which allows you to watch streams of a number of free and publicly available online TV stream sites.
https://www.rieter.net/content/
GNU General Public License v3.0
109 stars 36 forks source link

[Milhouse] AttributeError: 'module' object has no attribute 'PLAYER_CORE_DVDPLAYER' #658

Closed basrieter closed 8 years ago

basrieter commented 9 years ago

Original report by dofl (Bitbucket: dofl, GitHub: dofl).

Everything works fine, but I'm assuming this is a Kodi Jarvis error.

20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - Could not playback the url 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | Traceback (most recent call last): 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | File "/home/kodi/.kodi/addons/net.rieter.xot/resources/libs/plugin.py", line 497, in PlayVideoItem 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | playData = self.channelObject.PlayVideoItem(item) 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | File "/home/kodi/.kodi/addons/net.rieter.xot/resources/libs/chn_class.py", line 951, in PlayVideoItem 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | playerType = AddonSettings.GetPlayer() 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | File "/home/kodi/.kodi/addons/net.rieter.xot/resources/libs/addonsettings.py", line 95, in GetPlayer 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - | return [xbmc.PLAYER_CORE_AUTO, xbmc.PLAYER_CORE_DVDPLAYER][settingIndex] 20150912 11:01:52 - [1168MB] CRITICAL - plugin.py - 537 - + AttributeError: 'module' object has no attribute 'PLAYER_CORE_DVDPLAYER'

basrieter commented 9 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Yes, probably a Jarvis issue. I will have a look tonight.

basrieter commented 9 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

I just tried the 2015-09-12 (4d4c0d7) nightly and it is still OK there. What exact build do are you running?

basrieter commented 9 years ago

Original comment by dofl (Bitbucket: dofl, GitHub: dofl).

It was pretty bleeding edge and : https://launchpad.net/~wsnipex/+archive/ubuntu/xbmc-fernetmenta-master. I think it's better to stick to the official nightly builds and just close this.

basrieter commented 9 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

It is still weird, because it is still in the code at the Kodi GIT hub. I marked it as invalid for now. But I will keep an eye on http://kodi.wiki/view/Jarvis_API_changes to see what pops up there.

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Seems like this is only an issue on some Linux builds?

basrieter commented 8 years ago

Original comment by Henk (Bitbucket: Henk31, GitHub: Henk31).

I'm using the Openelec testbuilds for RaspberryPi from Millhouse on my Pi2 This morning I installed the latest build 1009 (http://forum.kodi.tv/showthread.php?tid=231092&page=103). Since the new videoplayer is installed in version 0908 (instead of dvd player) Retrospect doesn't work anymore. I attached the log.

Is there a solution for this problem?

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

@Henk31 Could you please attach a retrospect.log with DEBUG enable? See here: http://www.rieter.net/content/xot/troubleshooting/#Log_level_settings

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

It seems that Millhouse removed stuff from the Python api, which he shouldn't have done in this version (rather the next version). Posted in his thread.

basrieter commented 8 years ago

Original comment by Henk (Bitbucket: Henk31, GitHub: Henk31).

Isn't the one I attached the right one? I've got "log level = debug" enabled

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Let me recheck from my PC. Logfiles on my phone are not easy to read

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

@Henk31 you are right, it has the debug information, just not at the start, so ignore my previous post. I will go and try to discuss with Millhouse on the best way to do this. Personally I don't like the fact that he is using a modified Python API than the official Kodi code. Especially API's should be kept uniform in a single Kodi version. So all Jarvis builds should have the same API, but it could differ from the Kodi Isengard one.

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Apparently, they generate the Python API and cannot "just" add old players. So as always, it is up to Retrospect to get this fixed. So please try this addonsettings.py. First backup the existing one in the net.rieter.xot/resources/libs/addonsettings.py and then replace it with this version. It should fix your problem and default to Kodi to figure out the player.

basrieter commented 8 years ago

Original comment by Henk (Bitbucket: Henk31, GitHub: Henk31).

THX! It's working again. Great service!

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

You're welcome. I can't push this via a channel update, so just keep this file until version 4.0.1. I will leave the issue open so people with similar issues find it.

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Fixed: the Millhouse Kodi builds no longer have DVD Player but use the future VideoPlayer which broke Retrospect (See #658)

basrieter commented 8 years ago

Original comment by Patrics83 (Bitbucket: Patrics83, GitHub: Patrics83).

Wow! Thanks a lot Bas :D

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

You can always check out the Nightly repository: https://bitbucket.org/basrieter/xbmc-online-tv-nightly

Please do read the readme file (or the repo overview), just to be aware of the risks. And if you do use it, let me know if you have all the icons and graphics? I did some major reworks there.

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Those using us Milhouse build should use the GIT/Nightly 'master' branch. It should be working just fine.

basrieter commented 8 years ago

Original comment by 风黑 (Bitbucket: [黑 风](https://bitbucket.org/黑 风), ).

hello, the tvos had the same issue.

Jan 9 17:16:17 Apple-TV Kodi[2336] : Debug Print: EXCEPTION Thrown
(PythonToCppException) : -->Python callback/script returned the following error<--^M

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

True, they are based on the same sources. Please use the nightly/git builds and you should be fine.

basrieter commented 8 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

These fixes are now include in Retrospect 4.1.0 (http://www.rieter.net/content/2016/03/03/net-rieter-xot-4-1-0/)