search

retrospect-addon / plugin.video.retrospect

Retrospect is a Kodi video add-on which allows you to watch streams of a number of free and publicly available online TV stream sites.
https://www.rieter.net/content/
GNU General Public License v3.0
110 stars 36 forks source link

Kanal 9 - Not visible in Kodi 18 Retrospect channel settings #951

Closed basrieter closed 6 years ago

basrieter commented 6 years ago

Original report by Sopor (Bitbucket: Sopor, GitHub: Sopor).

When i open Retrospect channel settings the enable/disable channel for Kanal 9 is empty.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Correct it is a Kodi addon settings issue. We moved to a new internal format and it has some issues.

I will try to look into it soon.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Could you please attach the settings.xml from the net.rieter.xot/resources folder?

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

I tried my installations.

Kodi 18 nightly 20180416, Windows 10: I don't see anything after Kanal 5. Changing selection with the arrow keys, I can only move until TV3 then no more. With the mouse cursor, I can control TV4 and Dplay too, not Kanal 5.

Kodi 18 nightly 20180516, Windows 10: Same.

Kodi 18 nightly 20180416, Android TV: Same, but cannot move past TV3 with the remote.

Kodi 18 nightly 20180416, Android Samsung Galaxy S7 Edge: Everything working as it should.

All of them running latest Retrospect. Caused by same issue?

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

This is a Kodi issue as it seems. I am trying to discuss some of these with the Kodi dev that made changes. Will keep you all posted.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Issue #967 was marked as a duplicate of this issue.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Ok, the problem is that in Kodi Leia only 80 settings are allowed per settings category. As retrospect has > 80 channels, the enabled and bitrate settings already cause there to be >160 settings in the Channel Settings category (even though many of them are hidden).

The solution (besides winning the argument of bumping the limit) is to move some settings around. So I started with introducing a new context menu based on the Kodi context menu add-on structure. You can find that code in this branch: https://bitbucket.org/basrieter/xbmc-online-tv/branch/multi_select_enabled

Please feel free to try this new context menu and let me know. BTW: the settings are still broken in this version.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Ok, I had to re-do a lot of settings, because of the new limit of settings within a tab in the settings dialog. Please try this branch and let me know: https://bitbucket.org/basrieter/xbmc-online-tv/branch/multi_select_enabled

A lot of settings have moved to the context menu and I now use the official way of add-on context menu items. This speeds things up a lot, but does need to get used to a bit.

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

I tried it out. Great job! As you say it needs use to get accustomed to. What is cloaking a show? Hiding it?

Got to say, though, that I prefer it as it has been, to have all settings in the settings, so to speak. So the new Kodi makes that impossible?

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Cloaking (and uncloaking) has been in Retrospect for some time now and allows you to hide/unhide certain folders you don't want to see.

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

It's the word cloak that made me confused. It's hide for hiding a channel. I suggest to use hide for shows to. (In Swedish the same word is used, "dölj".)

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Nope, it stays 'cloak', it is very proper English.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Please download net.rieter.xot-4.1.7alpha27-KryptonLeiaOnly.zip to have this fixed. Be prepared for a lot of changes, more context menu items and dropping of compatibility with Kodi Jarvis and older.

https://bitbucket.org/basrieter/xbmc-online-tv/downloads/net.rieter.xot-4.1.7alpha27-KryptonLeiaOnly.zip

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

I didn't mean cloak is incorrect. What I aimed at is to use the same word for the same actions. Consistency is most times a good idea.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Hmm, perhaps I should reconsider. Let me give that a try tonight.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Changed: renamed and re-ordered some context menu items (See #951).

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

Looking good, Bas! The new menu system is a bit confusing at first, but once you get the hang of it it's ok. Time + use = suggestion of improvements. :)

Ready enough for translating the new strings to Swedish? (And Norwegian. @garvord )

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

If you take a look at the current English XML file and the Swedish one that these ID's where updated:

30059, 30060, 30083, 30095, 30098, 30504, 30506, 30507, 30517, 30563, 30564, 30565, 30566, 30571, 30572, 30573, 30574, 30575, 30576, 30577, 30578

Some might not be in the Swedish XML, but you can add them in the same location of the English one. Don't bother for the .po file, I generate those.

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

I'll translate them this weekend. I took a brief look and couldn't find where (Un-)Hiding items is used. Would be good to know the context.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Thanks! It is used as the Title for the dialog that is shown when a user hides a folder for the first time.

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

Here's the translation. Think it should be ok.

Some thoughts/notes:

Lastly, a suggestion: I think (un-]hide confuses, partly because the context menu don't use the same string for hiding and showing an object. Instead "Hide" and "Show" (50563 and 50564) is used. This is a suggestion:
-Show Item >>> Show Hidden Item

What do you think? /Mr Finicky :)

EDIT: Forgot this one: If you go to InputStream Adaptive settings from the Retrospect settings, then end InputStream Adaptive settings you don't get back to Retrospect settings. But maybe that's not possible?

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

Hey again Bas.

I found two things more I fixed in the Swedish translation. So you know what I changed:

To make it easier for you I'm making a new issue for the additional language suggestions above.

basrieter commented 6 years ago

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

So this is what I ended up with: https://bitbucket.org/snippets/basrieter/peggqp

Please comment on any changes in that snippet.