search

retrospect-addon / plugin.video.retrospect

Retrospect is a Kodi video add-on which allows you to watch streams of a number of free and publicly available online TV stream sites.
https://www.rieter.net/content/
GNU General Public License v3.0
111 stars 36 forks source link

Retrospect crash on continuous playback option (context option 'afspelen vanaf hier') #980

Closed basrieter closed 3 years ago

basrieter commented 6 years ago

Original report by Jeffrey Mons (Bitbucket: jqmons, ).

Retrospect crashes Kodi on continuous playback option. Occurs with both Uitzending Gemist and RTL channels. Normal episode by episode playback is without issue.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

What do you mean with "continuous playback option"?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Use context menu on an episode list (say a list of Sesame Street) , choose option: 'Vanaf hier afspelen'. Usually it would than playback all the episode in a row down the list.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

So what I would suggest is:

Does it always crash if you do that?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Running on recent Beta 1 of Retrospect, so yes most recent version. it worked ok on previous versions of the plugin though. Have been having the issue with previous versions of Retrospect. Worked ok in version 25 alpha remember. No updates done recently on KODI. Running LibreELEC 8.2.5 so have to wait for the Leia update as they haven't implemented yet.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Crash happens i.e. on RTL and Uitzending gemist; but works fine for playback of series in KODI itself. Also happens on all series and channels.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Kodi v17.6 "Krypton" is also the latest version for Raspberry PI. Kodi v18 "Leia" is still on Alpha 2 and rather unstable.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Your logs says you are on a very old Retrospect (alpha 14). So again, update tk a Kodi Nightly. It fixes a lot of playback issues.

I will verify when I am home.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Not all data was in the log, don't understand. Uploading recent log. I am on the most recent beta 1 build of Retropect.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

And are you playing from within The Netherlands?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Yes, from the Ziggo network. Strange thing is that it only crashes when selecting the context option 'vanaf hier afspelen'. Just selecting a single video in the list to play works fine.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

I am on Ziggo too. Will check later today. Does it crash on Krypton and Leia?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Crash Kodi Leia on PC (which I gave a clean install on Windows 10). Crash Krypton on Raspberry Pi (LiberELEC). Note it's not crashing the plugin itself, but the entire Kodi software. Btw the option in English is: ("Play from here"). It shows if you have a list of episodes from which to choose.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Please enable debug logging in Retrospect and try again, I am missing some vital information.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Ok, I can't reproduce this at all. Could you please describe the exact steps (including what items you are selecting) how you can make it crash?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Here a Youtube Video of me installing KODI + Installing Retrospect and showing the playback without problems and than crashing when doing the play from here option.

https://youtu.be/NfL32ejZPec

Also attached the retrospect log. After recording the video I activated the DEBUG logging option and crashed KODI again.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Check, same here now. Weird. Let me discuss this with the Kodi team.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Beta 3 resolved playback on Leia. Working fine, not crashing. Yet same Beta 3 on Krypton (Raspberry Pi LiberELEC) still crashing.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Funny, as I did not really change anything except a Belgian channel. But ok, perhaps it worked. Will give Kodi 18 Alpha 3 a spin.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Let me know if this issue can be closed.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Please keep ticket open. Working ok on Leia, but still crashing on Krypton.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Any update from KODI team?

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Yes, we can reproduce it, but it is related to fonts and the font cache and the person who knows about this is out on holiday. So no ETA.

basrieter commented 6 years ago

Original comment by Sopor (Bitbucket: Sopor, GitHub: Sopor).

I have been noticed the same issue when running it on my Vero 4K but in Windows with the same version 17.6 it works. Now suddenly it seems to work on my Vero 4K. I have no idea why.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

It is most likely a race-condition in Kodi that occurs for some vague reason.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Updated to Leia for now, issue does not happen there. Alpha from LibreELEC is quite good.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Ok, let me know your findings.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

It working fine on Leia. Sadly once I updated from beta 13 to 18 it started crashing. Even removing it and moving back to 13 did not help. Once installed it works 1 time or so, but once you have reboot it keeps rebooting when using the play from here option.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Any update from the team at Kodi? Still crashes.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

What Kodi version are you using at the moment that crashes it?

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Kodi 18 Beta 2 (LibreELEC (Leia) v8.90.005) with beta 20 of Retrospect.

basrieter commented 6 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

The probleem seems to lie with the context menu rendering. And that part is difficult to understand apparently. Perhaps report it as an issue at the Kodi trac issue tracker. Post that link to that issue here and I will see if I can push it up within the Kodi team. Feel free to link to this issue from the Kodi one.

basrieter commented 6 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Ticket created.

https://trac.kodi.tv/ticket/18057

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Are you still facing these issues with recent Leia Beta's?

basrieter commented 5 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Yes running LibreELEC v8.90.007 ALPHA (Kodi 18 Beta 5). Still crashing (not every time, but 90% of the time). First time after upgrading LibereELEC to new version it doesn't crash. Next time it does. Happens with every upgrade (the have a lot of updates).

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

@jqmons crappy. As we moved from Trac to GitHub with the Kodi issue tracker I would create a new issue on the Kodi GitHub site (perhaps mention it is also on trac).

Post the link here and I will see if a dev can have another look.

basrieter commented 5 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

Any guidance where to post on Kodi GitHub site?

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

https://github.com/xbmc/xbmc/issues

basrieter commented 5 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

XBMC; go for the classic! :-) Will post soon a ticket.

basrieter commented 5 years ago

Original comment by Jeffrey Mons (Bitbucket: jqmons, ).

No longer crashing. Installed Widevine and updated to LibreElec LibreELEC 9.0 (Leia) Beta 2.

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Great to hear that.

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Issue #1087 was marked as a duplicate of this issue.

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

I created an issue for this with Kodi as it still happens: https://github.com/xbmc/xbmc/issues/15290

Please report all your issues regarding this topic here.

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

Ok, one of the Kodi Devs can reproduce this and is trying to fix it. It indeed has something to do with the context menu items, but it seems difficult to pinpoint the exact issue.

basrieter commented 5 years ago

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).

...still there....