All storage, search, image processing and database-related packages and dependencies have been moved to the new node-common package. The most major change is moving sequelize to node-common, which required moving most of the dao code into the new package. The types (from dao/types) still reside in the common package as some of them are used in the frontend (and some of them might be needed in the future as well, so I haven't removed them completely).
Notes
I realize this is a quite huge PR, but most of the changes are basically replacing the import references with node-common instead of 'common'. I don't think a thorough review is needed, but wanted to create this PR, so that we could track when the changes got in.
Testing
Since there are quite a lot of changes, thorough smoke and/or regression testing will be needed to make sure nothing is broken after this massive refactoring. I've tested the builds, ran the app and all integration tests to make sure nothing major is broken, but I still could've missed something, so it's a good idea to test at least the main functionalities before releasing this change to the end users.
Fixes #1893.
Summary
All storage, search, image processing and database-related packages and dependencies have been moved to the new
node-commonpackage. The most major change is moving sequelize tonode-common, which required moving most of thedaocode into the new package. The types (fromdao/types) still reside in thecommonpackage as some of them are used in the frontend (and some of them might be needed in the future as well, so I haven't removed them completely).Notes
I realize this is a quite huge PR, but most of the changes are basically replacing the import references with
node-commoninstead of 'common'. I don't think a thorough review is needed, but wanted to create this PR, so that we could track when the changes got in.Testing
Since there are quite a lot of changes, thorough smoke and/or regression testing will be needed to make sure nothing is broken after this massive refactoring. I've tested the builds, ran the app and all integration tests to make sure nothing major is broken, but I still could've missed something, so it's a good idea to test at least the main functionalities before releasing this change to the end users.