search

rhiever / reddit-twitter-bot

Looks up posts from reddit and automatically posts them on Twitter.
GNU General Public License v3.0
137 stars 38 forks source link

Various questions #7

Open SylvainDe opened 8 years ago

SylvainDe commented 8 years ago

Hello, I've had a quick look at your nice script. I had a few questions:

Sylvain

rhiever commented 8 years ago

what is the "#dataviz" for in the post_text ?

My own customization to add hashtag for the DataIsBeautiful bot.

why are the title length 83 / 106 instead of the 140 I was expecting ?

To make room for the link, hashtag, and sometimes an image.

are you interested in any code change I'd perform for my personal usage ?

Depends what the changes are. If you'd like to propose a change that you think would be generally useful, file it as a suggestion in the issues and we'll discuss.

SylvainDe commented 8 years ago

Great, thanks for your quick answer.

So far as you know, the hard limit is indeed 140 characteres including the url and/or the image name ?

I'll submit a PR if I change anything which might be relevant to you/other people.

Thanks again!

SylvainDe commented 8 years ago

Actually, I got my answer here https://dev.twitter.com/overview/api/counting-characters / https://dev.twitter.com/overview/t.co , not an easy problem... :)

rhiever commented 8 years ago

Last I checked, yes, that is the limit. That was a year or two ago though.

On Wednesday, June 22, 2016, Sylvain notifications@github.com wrote:

Great, thanks for your quick answer.

So far as you know, the hard limit is indeed 140 characteres including the url and/or the image name ?

I'll submit a PR if I change anything which might be relevant to you/other people.

Thanks again!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rhiever/reddit-twitter-bot/issues/7#issuecomment-227739816, or mute the thread https://github.com/notifications/unsubscribe/ABo7tzFupJmKhQpvnsVGw9cTIRcU6vMSks5qOTW8gaJpZM4I7ub2 .

Randal S. Olson, Ph.D. Postdoctoral Researcher, Institute for Biomedical Informatics University of Pennsylvania

E-mail: rso@randalolson.com | Twitter: @randal_olson https://twitter.com/randal_olson http://www.randalolson.com

SylvainDe commented 8 years ago

@rhiever I've added various small changes on https://github.com/SylvainDe/reddit-twitter-bot/commits/devs . From my point of view, everyone could benefit from them. Do you prefer small PRs or huge PRs ? (The "Simplify the objects returned by get_reddit_posts" commit also fixes a potential issue by ensuring we save the image on the file system at the last moment so that it doesn't get overriden by another image by the time we use it).

rhiever commented 8 years ago

It'd be preferable to have PRs lumped by different new features. ie, one PR per issue.

On Thursday, June 23, 2016, Sylvain notifications@github.com wrote:

@rhiever https://github.com/rhiever I've added various small changes on https://github.com/SylvainDe/reddit-twitter-bot/commits/devs . From my point of view, everyone could benefit from them. Do you prefer small PRs or huge PRs ? (The "Simplify the objects returned by get_reddit_posts" commit also fixes a potential issue by ensuring we save the image on the file system at the last moment so that it doesn't get overriden by another image by the time we use it).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rhiever/reddit-twitter-bot/issues/7#issuecomment-228182609, or mute the thread https://github.com/notifications/unsubscribe/ABo7twhRPUMghXEBj-cFL-WrgH8FfLt3ks5qOvQ4gaJpZM4I7ub2 .

Randal S. Olson, Ph.D. Postdoctoral Researcher, Institute for Biomedical Informatics University of Pennsylvania

E-mail: rso@randalolson.com | Twitter: @randal_olson https://twitter.com/randal_olson http://www.randalolson.com

SylvainDe commented 8 years ago

Great! I'll do this one PR at a time to avoid getting into a merging nightmare.