search

rhomeister / api_postcode_nl

MIT License
2 stars 3 forks source link

Migrate to api.postcode.eu #10

Open jessevdp opened 11 months ago

jessevdp commented 11 months ago

Hey 👋

I noticed api.postcode.nl has changed to api.postcode.eu.

Their site https://developer.postcode.eu/ doesn't really seem to provide any information about the switch, what's changed, or about deprecation of api.posstcode.nl. But I still wanted to get this issue on the radar.

It seems like they support more countries now. So I can imagine that this switch isn't as simple as flipping the URL.

Are there any plans to update this gem?

jessevdp commented 10 months ago

I have some additional info about the migration to api.postcode.eu (in dutch)

Pas hiervoor API aanroepen als volgt aan:

api.postcode.nl/rest/addresses/2012es/30
api.postcode.nl/rest/addresses/postcode/2012es/30

worden:

api.postcode.eu/nl/v1/addresses/postcode/2012es/30

api.postcode.nl/rest/postcode-ranges/postcode/2012es wordt:

api.postcode.eu/nl/v1/postcode-ranges/postcode/2012es

Verdere aanpassingen in je implementatie zijn niet nodig! Je kunt voortaan gewoon gebruik blijven maken van het nieuwe domein.

I haven't looked into the gem code yet, but it seems a simple change in the API paths should suffice.

If I submit this patch, will it be accepted? And will a new version be published? Or am I going to need to fork / monkey-patch / roll my own?