search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

111, initial commit, JENKINS_OPTS put into params/jenkins/build file,… #115

Closed jtprichett closed 6 years ago

jtprichett commented 6 years ago

resolves #111

sherl0cks commented 6 years ago

@JoshuaTPritchett first, I updated your comment. The resolves will close the issue automatically if this PR is merged

as to the content of the PR, this one is a bit trickier because we need to modify the DeployConfig, not the BuildConfig, and currently this repo uses the out of the box openshift deployment template. We recently agreed to move to a custom jenkins deploy template, so this work could be very helpful.

basic what you need to do is to add a template based on oc get template jenkins-ephemeral -n openshift -o yaml. Make sure the template is yaml, not json. Then you can add your env to new template. Make that change, and we can go from there.

jtprichett commented 6 years ago

Just a couple quick notes: 1) When using Ansible on Ubuntu 16.04 it must be updated otherwise casl-ansible will not work (Ansible 2.1 or something crazy!) 2) Consider adding examples to the README for tagging with the openshift-applier roles for casl instead of just hard referencing docs

sherl0cks commented 6 years ago

@JoshuaTPritchett we tend to stay on the bleeding edge of ansible. I'm testing with 2.4.2.0 right now. We're in process of providing a docker container to actually do the playbook runs so this is a bit easier.

https://github.com/rht-labs/labs-ci-cd/issues/113 update RE: docs

jtprichett commented 6 years ago

It's cool, I tested with casl-ansible. I believe my changes are going to be good to go, let me know and I'll finalize this today.

sherl0cks commented 6 years ago

@JoshuaTPritchett looks like Jenkins ephemeral and the new persistent entry are using the same params file, which is messing up the CI job because the params file is modified twice.

I need to check in with my team around moving to jenkins peristent, now may be a good time

sherl0cks commented 6 years ago

@JoshuaTPritchett I checked in with the team. let's move this to the persistent template, so please remove the ephemeral template completely from the inventory and template inventory. then we can rerun the CI and go from there

jtprichett commented 6 years ago

@sherl0cks sounds, good, I put both to see which you would prefer. Would it be better to remove, or leave in case someone else wants to use it, but just remove from inventory?

sherl0cks commented 6 years ago

@JoshuaTPritchett remove. in general, we want this inventory to be prescriptive.

jtprichett commented 6 years ago

Done.

jtprichett commented 6 years ago

@sherl0cks What's the status on this? Is there something I missed?

sherl0cks commented 6 years ago

@JoshuaTPritchett good work.