search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

ansible-galaxy run in a container for stability #157

Closed literalice closed 6 years ago

literalice commented 6 years ago

In the README document, the run.sh must need only docker runtime, but actually we need to install ansible-galaxy in a machine directly for executing run.sh .

I think ansible-galaxy should be run in a container same as ansible-playbook command.

sherl0cks commented 6 years ago

galaxy is in the container, but there is a regression in the applier container - it no longer ships git. We'll get this fixed upstream. https://github.com/redhat-cop/openshift-applier/issues/18

@oybed :point_up:

sherl0cks commented 6 years ago

@literalice can you update the script to consume v3.9.0 tag from here instead: https://hub.docker.com/r/redhatcop/openshift-applier/tags/?

That tag should have the bug fixed.

oybed commented 6 years ago

@literalice @sherl0cks as the script doesn't specify a specific tag of the container image, this should just work as-is now with the latest image.

However, I'd recommend updating the galaxy requirements file to use the v3.9.0 tag for other purposes. https://github.com/rht-labs/labs-ci-cd/blob/master/requirements.yml

sherl0cks commented 6 years ago

just like we are pinning tags in other places, I'd like to pin it here too

literalice commented 6 years ago

@sherl0cks @oybed Thank you for promptly handling the matter with care! I agree to specifying the tag for preventing unexpected regression. I've updated the PR, so would you check it?

sherl0cks commented 6 years ago

@literalice I'm running a test now. run.sh, due to its nature, doesn't run through our CI. But I am actually testing by recreating the CI infra with your change. Should have feedback shortly.

sherl0cks commented 6 years ago

@literalice looks good. Thanks for the change! Do let us know if you have any issues or feature requests.