search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

remove old npm slave and add new upstream one #160

Closed sherl0cks closed 6 years ago

sherl0cks commented 6 years ago

resolves #158

sherl0cks commented 6 years ago

@springdo could you review this change? There is info here relevant to your work right now. @rdebeasi @mdanter @mcanoy @pcarney8 @logandonley @InfoSec812 FYI

springdo commented 6 years ago

Cool man, I'll take a look in more detail when I get in to the office!

springdo commented 6 years ago

@sherl0cks - if you are going to remove the Chrome install from the Dockerfile; can we create a new one that has it please? Im guessing you'll probs just want this created in CoP land? (don't mind taking on that responsibility if you just wanna get your changes in now)

sherl0cks commented 6 years ago

@springdo hmmm - didn't really think through that. good catch. I think we may want to push it all the way upstream to openshift, not the CoP. I'll open an issue in openshift land to get the discussion started, though they are likely not going to want to do it. if we go CoP route, the current issue is that the new openshift jenkins slaves builds aren't pushed to the red hat contianer registry yet, so you need to build the base image first in order to extend it.

sherl0cks commented 6 years ago

@springdo see https://github.com/openshift/jenkins/issues/570. for now, let's close this out and then based on the outcome of the openshift ticket, we can create a new slave in CoP land if it make sense.

springdo commented 6 years ago

yeah man; that's cool. If we don't hear much from the guys in OCP land soon I'll shove it into the CoP. Will merge your stuff for now