rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

Feature/jenkins s2i updates #167

Closed springdo closed 6 years ago

springdo commented 6 years ago

closes #165 and some other stuff i didn't raise issues for. basic things covered in this are

springdo commented 6 years ago

@sherl0cks, @pcarney8 or @makentenza - any chance we can start closing out some of these MR and get mergé? 💃

sherl0cks commented 6 years ago

as stated in #166, repeating here in case folks come across these separately.

@oybed @pcarney8 @rdebeasi @mcanoy - please also be advised.

@springdo - the reality is that I cannot support this in the appropriate time frame. if you can not get any other takers from the team, I support you self merging (not just this PR, but in general) under the following criteria:

springdo commented 6 years ago

On the basis that CI works and is passing, the changes here are minimal and I will mergé myself. CI initially failed; i fixed an things are now working. Merging.

🥇