search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

fix the BUILD_URL/need to save config issue #183

Closed pcarney8 closed 6 years ago

pcarney8 commented 6 years ago

also increase the container cap so pods don't hang

logandonley commented 6 years ago

The container cap part looks good and functioned as expected. But I agree with the others, that the JENKINS_URL field should at least be changed to something more generic, but ideally something along the lines of what @mcanoy suggested.

pcarney8 commented 6 years ago

@mcanoy @logandonley I put kevin's suggestion right into the configure-jenkins.groovy file!

@oybed removed JENKINS_URL

mcanoy commented 6 years ago

One other note here. This will only work when the route is named jenkins. We pretty much always use this name. If we want to cover edge cases I would recommend looking at using a label that we can use by convention. I would suggest the name label. Then we could pull that label from the running pod and assume by convention that the route would use this name as well - or we could add that label to the route

oc get po $HOSTNAME} -o jsonpath={.metadata.labels.name}

pcarney8 commented 6 years ago

@mcanoy yeah good point. I was just trying to get this up as quickly as possible. i'll add that on when i have time