search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

Update to get pod label and then use that for the route (more dynamic fix the `BUILD_URL` issue) #197

Closed pcarney8 closed 6 years ago

sherl0cks commented 6 years ago

@pcarney8 lgtm, but can you please run the CI job first?

springdo commented 6 years ago

@sherl0cks, @pcarney8 - I've run the CI Job for you. I'll mergé if it's not borked!

springdo commented 6 years ago

Seems to be some issue with the zap slave. Let me re-run it incase it was just being flakey....

08:45:54 [ZAP] [labs-ci-cd-pr-197-test-slaves-pipeline] Running shell script
08:45:54 [ZAP] + /zap/zap-baseline.py -r index.html -t https://google.com
08:45:55 [ZAP] _XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
08:46:03 [ZAP] Jul 31, 2018 8:46:02 AM java.util.prefs.FileSystemPreferences$1 run
08:46:03 [ZAP] INFO: Created user preferences directory.
08:48:10 [ZAP] 2018-07-31 08:47:55,624 I/O error(5): Failed to connect to ZAP after 120 seconds
08:48:10 [ZAP] ERROR Failed to connect to ZAP after 120 seconds
pcarney8 commented 6 years ago

@springdo looks like Build 121 passed. Mergé?

sherl0cks commented 6 years ago

@springdo - I like the added checks in the jenkins job! just seeing that.

@pcarney8 lgtm

sherl0cks commented 6 years ago

@pcarney8 is there an issue this resolves that needs closing?

pcarney8 commented 6 years ago

@sherl0cks no, :grimacing: i believe i forgot to open an issue. i know PR #183 addressed this issue first, this is really just an enhancement to that fix

sherl0cks commented 6 years ago

no worries, just trying to keep the backlog clean