search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

Fixing hoverfly #221

Closed tylerauerbeck closed 6 years ago

tylerauerbeck commented 6 years ago

It looks like we previously removed the livenessprobe and readinessprobe from hoverfly because they were causing failures. These failures were caused due to the fact that hoverfly was only listening on the loopback address. This PR fixes this by passing in the appropriate args to have hoverfly listen on all interfaces.

InfoSec812 commented 6 years ago

I tested this change and there needs to be one small addition:


spec:
      containers:
        - args:
            - '-listen-on-host'
            - 0.0.0.0
            - '-ap'
            - '8888'
            - '-pp'
            - '8500'
          command:
            - hoverfly

Adding the -pp 8500 -ap 8888 makes it work perfectly

tylerauerbeck commented 6 years ago

@InfoSec812 I'll take a look at this, but I am a little confused. I believe those are the default ports and if they aren't working appropriately (by default versus having to specify them), I'm a little confused as to how the liveness and readiness probes were working without specifying them.

I should have some time later this afternoon to take a look / get this updated.

InfoSec812 commented 6 years ago

@tylerauerbeck I tried again without those params and you are correct. They are not needed. Not sure why it didn't work for me the first time around.