search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

Consider Moving from {{ playbook_dir }} to {{ inventory_dir }} #261

Closed sherl0cks closed 5 years ago

sherl0cks commented 5 years ago

If distribute Labs CI/CD via galaxy, moving to inventory dir would allow consumers to write playbooks like the one found in #260 , instead of requiring Labs CI/CD to maintain such playbooks. This would allow consumers to reuse our inventory (and its excellent filter tagging), reducing their maintenance overhead.

sherl0cks commented 5 years ago

See https://github.com/sherl0cks/container-pipelines/tree/secure-spring-boot-pipeline as an example of how this would work.

oybed commented 5 years ago

+100 We have always promoted using inventory_dir as part of openshift-applier work, and it is reflected in all the original openshift-applier and most of CoP work as well + it is also in the applier tests

sherl0cks commented 5 years ago

Just spoke with @pcarney8 . He is OK with moving to inventory dir. I will send a PR for this.