search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

Update slave versions and fix to CoP land repos #274

Closed springdo closed 5 years ago

springdo commented 5 years ago

Updated the slaves to the latest cut of container-quickstarts. I would like to move the config more towards params_from_vars too as there is soo much repetition in the params dir

springdo commented 5 years ago

@pcarney8 what's your thoughts on getting this in to update all our slave refs and then circle back to thinking about if we should use vars_from_params for these puppies?

pcarney8 commented 5 years ago

@springdo can you try changing your label from label: "jenkins-slave-ansible" to label: "jenkins-slave-ansible:v3.11 ? curious to know if that solves this problem.

It'd be nice to keep the v3.11 vs v3.9 vs v4 tag on there because then we wouldn't have confusion over what "latest" is.

Either way, I think the jenkins-slave-generic-template.yml should probably be defaulted to latest and then we should really specify the same v3.11 tag here because we are explicitly using the v3.11 jenkins-slave-base image. I'm going to put a PR on redhat-cop/containers-quickstarts to change that default. will update here

pcarney8 commented 5 years ago

@springdo see https://github.com/redhat-cop/containers-quickstarts/pull/208