🎈 FIX - remove the need to build pact & point to new auth template 🎈

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components

Apache License 2.0

101 stars 70 forks source link

🎈 FIX - remove the need to build pact & point to new auth template 🎈 #290

Closed springdo closed 4 years ago

springdo commented 5 years ago

@pcarney8 (or whoever else) This PR should not be merged until we get https://github.com/redhat-cop/openshift-templates/pull/49 merged and off the back of it bump the version of openshift-templates to v1.4.12 as i've pre-emptively bumped the dependency in ci-cd to it

partly towards closing of #286

springdo commented 5 years ago

Other PR is in so this should be good to go shortly

pcarney8 commented 5 years ago

@springdo I've included your changes in my PR #289 because i needed to update to openshift-templates to v1.4.12 it looks like pact-broker defaults all of your vars (mine is working without them), do you want to keep those in there? if so, i'll add them and we can close this PR

oybed commented 5 years ago

@springdo @pcarney8 Based on above convo, can we close this PR?