search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

clean up sonar docker build #56

Closed sherl0cks closed 6 years ago

sherl0cks commented 6 years ago

These are carry over issues from after the merge: https://github.com/rht-labs/openshift-sonarqube/issues/18

InfoSec812 commented 6 years ago

SONAR_WEB_JVM_OPTS is still in use HERE

SONAR_PLUGINS_LIST is still used HERE

sherl0cks commented 6 years ago

@InfoSec812

InfoSec812 commented 6 years ago

Yep, you're right... The list IS hard coded.

sherl0cks commented 6 years ago

Ok - should we remove SONAR_PLUGINS_LIST or just set those values to the default on the template?

InfoSec812 commented 6 years ago

We can remove it I believe.

InfoSec812 commented 6 years ago

Fixed