search

rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

move *-build-pod to jenkins-slave-* #75

Closed sherl0cks closed 6 years ago

sherl0cks commented 6 years ago

the term build pod is confusing. replace with jenkins slave a la https://github.com/rht-labs/labs-ci-cd/tree/master/docker/jenkins-slave-ansible

pcarney8 commented 6 years ago

@sherl0cks do you want it ansible-jenkins-slave or jenkins-slave-ansible? i noticed mvn-jenkins-slave and npm-jenkins-slave in there currently. I'm going to go through make all the naming conventions the same, just let me know which way you prefer.

sherl0cks commented 6 years ago

I have waffled back and forth. which do you think reads better? i'm open on this

pcarney8 commented 6 years ago

well, after i just refactored to *-jenkins-slave I realized it jumbles everything up, aka they're not all right next to each other in the file system. I think having jenkins-slave-* at least groups them together when they are in alphabetical order, so it makes them easier to find

sherl0cks commented 6 years ago

sounds good to me.

springdo commented 6 years ago

Im in favour of the @pcarney8 suggestion - jenkins-slave-${BUILDER_NAME} tbh. I like how it reads with similar items grouped together and as this repo grows, plus the types of these we may encounter in the future; it could be useful having them grouped.

sherl0cks commented 6 years ago

agreed and I do believe this is the approach taken in #76

sherl0cks commented 6 years ago

resolved by 76