rht-labs / labs-ci-cd

👻UNMAINTAINED - A collection of Red Hat Open Innovation Labs CI/CD components
Apache License 2.0
101 stars 70 forks source link

jenkins-slave-ansible params should point to the rht-labs/labs-ci-cd repo #88

Closed springdo closed 6 years ago

springdo commented 6 years ago

The SOURCE_REPOSITORY_URL in the params/jenkins-slave-ansible/build file should reference the one in this repo; not @sherl0cks one.... SOURCE_REPOSITORY_URL=https://github.com/sherl0cks/labs-ci-cd

Happy to PR and fix if it's helpful and not naggy! :)

sherl0cks commented 6 years ago

yea I'm aware of this one. you are welcome to fix if you'd like.

I don't normally merge my own PR's, but the nature of committing a CI system sort of requires it. and of course skipping PR reviews means mistakes =)

springdo commented 6 years ago

Yeah man - I totes get it! Sometimes for progress / change you just gotta go for it ! I'll get PR to ya now shortly

sherl0cks commented 6 years ago

resolved via #90