riboseinc / rails-keyserver

A generic Rails engine for serving most kinds of keys
MIT License
2 stars 0 forks source link

Use only iv column and not salt by default #18

Closed ribose-jeffreylau closed 5 years ago

ribose-jeffreylau commented 5 years ago

https://github.com/attr-encrypted/attr_encrypted#the-mode-option

Our dependency on attr_encrypted means this project should act on deprecations on modes involving salt.

Since we haven't released any official versions, I think it's safe to directly remove mentions of salt in the code, e.g., db/migrate/20180822000001_create_schema.rb, without risking breakage of other people's production code.

ronaldtse commented 5 years ago

Agreed!