richibrics / IoTuring

Your Windows, Linux, macOS computer as MQTT and HomeAssistant integration
https://pypi.org/project/IoTuring/
GNU General Public License v3.0
70 stars 6 forks source link

Monitor: add support to change monitor mode for Windows #36

Closed richibrics closed 1 year ago

richibrics commented 1 year ago

Signed-off-by: tsunglung tsunglung@github.com

infeeeee commented 1 year ago

Copying my comment from the other PR:

It think this should be separate from this Monitor command, as ExternalDisplay or DisplayConfiguration or something, and they could be displayed as a Select Entity in HomeAssistant:

niceboygithub commented 1 year ago

Agree.

niceboygithub commented 1 year ago

there are only two Entity_type 'sensor' and 'button'.

Will you implement select entity?

infeeeee commented 1 year ago

there are only two Entity_type 'sensor' and 'button'.

Will you implement select entity?

In Ioturing there are only commands and sensors. This will be a command, but it will be displayed as a select in Home Assistant only.

richibrics commented 1 year ago

I can't push here my commits because I have no permissions. Do I create my own branch from this pull request ? @infeeeee

infeeeee commented 1 year ago

The owner of the branch can set "allow edits from maintainers". https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I enabled this on my PRs, that's why you could commit there.

So @tsunglung can enable this, or you have to create a new branch

Edit: but you created the PR, from @tsunglung 's branch, so I don't know actually.

richibrics commented 1 year ago

Yes I think @tsunglung needs to do it as its hir repo. Tomorrow I create a new branch if I am not able to do that, thanks

tsunglung commented 1 year ago

image I only see "blocked" message, can not find the checkbox to enable "Allow edits from maintainers."

richibrics commented 1 year ago

@tsunglung It should be on the right side under the Subscribe/Unsubscribe button

tsunglung commented 1 year ago

not see the checkbox. image

richibrics commented 1 year ago

no problem, merging this PR into my own branch for this entity