richibrics / IoTuring

Your Windows, Linux, macOS computer as MQTT and HomeAssistant integration
https://pypi.org/project/IoTuring/
GNU General Public License v3.0
70 stars 6 forks source link

AppInfo Enhancements #92

Open infeeeee opened 9 months ago

infeeeee commented 9 months ago

Some enhancement ideas about AppInfo entity

richibrics commented 7 months ago

Yes correct, if install by git we could check in that way. For AppInfo, do you mean avoid having multiple entities for those two information ?

infeeeee commented 7 months ago

Appinfo shows up as 3 sensors in HA: Name, Update and Version. Name and Version could be merged as one, where version is just an extra attribute, or something like that. I was thinking maybe 3 sensors for this is a bit overkill, and they most of the time just static data. I think they were created before extra attributes.

richibrics commented 7 months ago

Would it be better to have the version in the Name or in the Update ? I think the name would have sense to store app information as extra, but the Update is directly related to the version update so it would be good also there.

richibrics commented 7 months ago

An enhancement would also to update the app using a command, so to create an Update entity in Hass

infeeeee commented 7 months ago

Would it be better to have the version in the Name or in the Update ?

I don't know, this was just an idea to declutter a bit, whatever looks better. maybe in the Name, or both? I just wanted to write this down so it won't be forgotten.

An enhancement would also to update the app using a command, so to create an Update entity in Hass

Yes, that would be awesome. But it would need a lot more work, some code for detecting install method, and how IoTuring is run to restart it. Or maybe auto update should only work if autostart is set up from configuration? So this should be implemented after #39

richibrics commented 7 months ago

If I'm not wrong Python allows to know the command that started the script, and the script should already have the permissions to start itself again with the same permissions so I would leave it separated from the autostart thing

richibrics commented 7 months ago

I'll start with AppInfo changes