richstu / nano2pico

Code to produce analysis ntuples (pico) from the CMS NanoAOD.
2 stars 4 forks source link

Adding kinematic fit #33

Closed andersbarzdukas closed 7 months ago

andersbarzdukas commented 8 months ago

Changes: -Added kinematic refit and subsequent variables to picos (not using rochester corrected pT) -Changed photon requirement to include photon_wp80, mindr > 0.3, and photon_elidx==-1 (overlapping object rejection) -Added lepton charge requirement and removed ll_charge branch -Changed skim requirements to require nll>=1 -Added photon_jet_maxdr, PTt variables, and llphoton_dijet_dr -Added lep* to skim variables -Changed use_event to be true for data

For kinematic refit changes please look at kingscanyon_v1.addingkinematicfit/ picos on cms11. Some other changes are not included in these test picos

Possible additions before merge: -Adding pixelseed veto to photon reconstruction -Other changes?

mcoshiro commented 8 months ago

One possible suggestion to consider: perhaps we should only require photon_elidx does not point to a signal electron. The current scheme removes all photons that appear in the pico electron list (that pass pt, eta, dxy, and dz cuts, but not necessarily ID), but this introduces extra complication for synchronization, and possibly a loss of efficiency.

Other than that, the other changes all look good to merge to me.

andersbarzdukas commented 8 months ago

I added the change to photon definitions in the most recent push. The definition of a photon should reject photons if the el_sig variable at that particular photon_elidx index is true. If the photon is not in the electron list it should always pass this criteria.

I also had forgotten to include the most up to date variables file, so that should be good now as well.

andersbarzdukas commented 8 months ago

Ok I believe I have made all the requested changes with the last push. I will look into the other variables and include then either as new variables or change the current ones when we come to a decision on that.

andersbarzdukas commented 7 months ago

Pull Request passed review. Will merge now