rigetti / qiskit-rigetti

Qiskit provider serving Rigetti hardware & simulator backends.
Apache License 2.0
8 stars 5 forks source link

Update for Qiskit 1.0 #50

Open frankharkins opened 7 months ago

frankharkins commented 7 months ago

Minor tweaks to make this project work with Qiskit 1.0

I couldn't get the test suite working on my machine but I can take a look if anything fails in CI.

MarquessV commented 7 months ago

@frankharkins Thank you for doing this! I approved CI to run on this PR. Looks like tests are failing due to ImportError: cannot import name 'UnitaryGate' from 'qiskit.circuit.library'.

Also, are these changes intended to be compatible with the Qiskit version this library currently supports (>=0.38)? Just want to check if we should update the constraint in pyproject.toml.

frankharkins commented 7 months ago

Hi, sorry I missed this. I've just pushed a commit that should add backwards compatibility for earlier Qiskit versions, so hopefully you won't need to update your dependencies.

frankharkins commented 7 months ago

I'm not sure why the tests failed. QuantumCircuit.qasm has been removed so that will need updating, but that shouldn't have caused the test to fail as it's still using qiskit<=1.0. Unfortunately I can't look at it next week, but feel free to push to my branch or merge to a feature and work on it there. If it's still open I'll take a look when I'm back.

Here's the migration guide I've been using: https://docs.quantum.ibm.com/api/migration-guides/qiskit-1.0-features