search

rishjaiswal / java-automation-framework

Testing Framework Created from Scratch Based on Java using Maven and TestNG
MIT License
1 stars 1 forks source link

Refactoring -Singleton Implementation #18

Closed rishjaiswal closed 3 years ago

rishjaiswal commented 3 years ago

Singleton Implementation in ConfigReader.java - Refactored Code

rishjaiswal commented 3 years ago

Looks good

rishjaiswal commented 3 years ago

Need to add below optimisation code for DriverUtils.Java

driver.manage().deleteAllCookies();
driver.manage().timeouts().implicitlyWait(30,TimeUnit.SECONDS);
driver.manage().timeouts().pageLoadTimeout(30,TimeUnit.SECONDS);
rishjaiswal commented 3 years ago



rishjaiswal commented 3 years ago

Can you refactor SeleniumUtils.java and remove Thread.sleep()

Since we are using now ImplicitlyWait() method.