risk-of-thunder / R2API

A modding API for Risk of Rain 2
https://thunderstore.io/package/tristanmcpherson/R2API/
MIT License
136 stars 55 forks source link

DirectorAPI: AddNewMonsterToStage adds monsters to all monster families even when addToFamilies is set to false, along with other weirdness. #398

Closed Moffein closed 2 years ago

Moffein commented 2 years ago

Was playing some runs with Clay Men and some other mods that use this DirectorAPI function, but noticed really weird behavior postloop.

I've had other Clay Men users report these exact same issues listed here. I checked the console log but no DirectorAPI-related errors showed up whenever any of this weird behavior happened.

LogOutput.log

xiaoxiao921 commented 2 years ago

Thanks for this report, looking at the code, it seems I simply ignored the potential existence of the vanilla VoidInvasion pool category, some stages have their categories like this :

Right now, even with addToFamilies set to false, the card will be added to the DCCSs under the VoidInvasion pool category no matter what, does simply not adding them when the bool is set to false a good enough fix for you ?

For stage 8, not sure why this happens, I imagine this is intended, it can be easily checked with something like UnityExplorer and checking the family DCCS and check the cards in it.

Moffein commented 2 years ago

does simply not adding them when the bool is set to false a good enough fix for you ?

Sounds good to me.