risk-of-thunder / R2API

A modding API for Risk of Rain 2
https://thunderstore.io/package/tristanmcpherson/R2API/
MIT License
136 stars 55 forks source link

Prefab API adding every cloned networked prefab to an R2API serializable content pack for no reason #508

Open Priscillalala opened 11 months ago

Priscillalala commented 11 months ago

Prefab API creates a serialized content pack for every mod that wants to clone a networked prefab and adds that prefab to the networked objects collection. This behavior makes no sense because most of these prefabs need to be in the character bodies, masters, projectiles, etc. collections anyway, and because it is needlessly coupling these two things together.

PrefabAPI creating serialized content packs for mods that have no need for them is a needless annoyance.

In my opinion, this should be removed save for maintaining backwards compatibility, because this functionality is already provided by ContentManagement itself. But there should be an option to opt out through PrefabAPI at the very least. Whole ContentManagement system is off the rocker anyway so this is really just here as a reminder to me and Nebby to work on this.