search

rkusa / DATIS

DCS World Automatic Terminal Information Service (ATIS) broadcasted through Simple Radio Standalone (SRS)
MIT License
90 stars 21 forks source link

Active rwy override #76

Closed talbotmcinnis closed 3 years ago

talbotmcinnis commented 3 years ago

PR relevant only after AllowParametersInAnyOrder is merged, but this adds a new option to airfields, to override the active runway for scenarios where the prevailing winds do not dictate the active runway.

rkusa commented 3 years ago

Thank you so much for the PR! It will probably take until after Christmas before I finally find the time to look into your other PR and this one again. Sorry that it currently takes so long

talbotmcinnis commented 3 years ago

I’m not in any rush Markus. It’ll get done when the time is right. I’d rather go slow and do it right than rush through every bit of junk:)

I’ve likely got one or two more coming, but please don’t see those as extra pressure.

We are getting close to a version that will work within the 476th so I will likely start internal builds for testing.

Happy holidays!!

On Dec 19, 2020, at 05:39, Markus Ast notifications@github.com wrote:

 Thank you so much for the PR! It will probably take until after Christmas before I finally find the time to look into your other PR and this one again. Sorry that it currently takes so long

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

talbotmcinnis commented 3 years ago

Ok, I managed the rebase... it's showing a small conflict which I am not sure if I can resolve or you need to do that? Sorry I'm new to this multi-origin stuff :)

rkusa commented 3 years ago

Thanks @talbotmcinnis, I've fixed the remaining merge conflict and merged it into master here 4ef2873e2ea10ba00398a445e6145290a3212d35 (since I've merged and pushed using the command line, the PR itself will not show it merged, so I'll have to close the PR manually)