search

rkusa / DATIS

DCS World Automatic Terminal Information Service (ATIS) broadcasted through Simple Radio Standalone (SRS)
MIT License
91 stars 22 forks source link

Qnh override #92

Closed talbotmcinnis closed 3 years ago

talbotmcinnis commented 3 years ago

This started with the goal of being able to work around the temperature/pressure issue we discovered a while back. Our squad is very sensitive to the expected QNH setting causing an exact match to aircraft values at the EOR areas,

QNH 30.02 is a supported option.

However this exposed challenges applying that override to QFE. Thus I included something I've been meaning to do anyway, add "NO QFE" and "NO HPA" options to suppress those from the remarks sections.

As always, welcoming all feedback. Cheers.

rkusa commented 3 years ago

Thanks for the PR! Would you mind giving https://github.com/rkusa/DATIS/pull/93 to see if we maybe don't even need the override?

talbotmcinnis commented 3 years ago

Will do! Exciting!

On Apr 25, 2021, at 12:13, Markus Ast @.***> wrote:

 Thanks for the PR! Would you mind giving #93 to see if we maybe don't even need the override?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

rkusa commented 3 years ago

v3.0.1 hopefully fixes the QNH deviations so that we don't need the QNH override. Adding NO QFE and NO hPa (we might wanna make hPa case-insensitive so that it works for both NO HPA and NO hPA, wdyt?) is still fine for me.

talbotmcinnis commented 3 years ago

Good idea regarding case sensitivity. I will remove the qnh override now. I also am not attached to the exact phrasing so feel free to make a change if you wish. I'll try to push my changes tonight or Monday.

talbotmcinnis commented 3 years ago

Ok, QNH OVERRIDE option has been removed, NO X options are now case insensitive, and the branch has been deconflicted.

Let me know if you see anything else, otherwise as far as I'm concerned this is ready to merge :)

rkusa commented 3 years ago

⛵ released as part of https://github.com/rkusa/DATIS/releases/tag/3.1.0