search

rlxone / Equinox

🌇 🌃 Create dynamic wallpapers for macOS.
https://equinoxmac.com
MIT License
1.24k stars 36 forks source link

Add FR localization #20

Closed W1W1-M closed 2 years ago

W1W1-M commented 2 years ago

Hello @rlxone I really think Equinox is a good idea and I wanted to contribute. I've setup the project for localization and added a french translation (my second tongue). I see version 1.1 is in the works, do you prefer localizations to be merged directly into main or version1.1 branches ? Regards

rlxone commented 2 years ago

Hi, @W1W1-M Thank you a lot for the French localization! Looks awesome! Yep, I'm planning to release the 1.1 version with some minor bugfixes after the macOS Ventura release, because they rewrote system settings from scratch in SwiftUI (as I remember) so I need to be sure everything works fine. I'll merge your branch as the last feature of 1.1 release. Btw, could you be the first point of contact when i need to update french localization?

W1W1-M commented 2 years ago

Thank you a lot for the French localization! Looks awesome!

Glad to give back a bit, hope It makes future localizations easier. I'd like to contribute some more and this is a way to get into Mac apps coming from iOS.

Yep, I'm planning to release the 1.1 version with some minor bugfixes after the macOS Ventura release, because they rewrote system settings from scratch in SwiftUI (as I remember) so I need to be sure everything works fine. I'll merge your branch as the last feature of 1.1 release.

Ok 👍

Btw, could you be the first point of contact when i need to update french localization?

Yes that's fine, keep me updated as needed.

rlxone commented 2 years ago

Yes that's fine, keep me updated as needed.

Sweet!

Thank you for the fixes, looks good to me. I'll ping you over time when ready to merge.

rlxone commented 2 years ago

hey @W1W1-M, i need your help with translating some strings from your previous PR. https://github.com/rlxone/Equinox/pull/25/files#diff-0582cb73e1951afc53f9a389a765e5fa1d34581e9d988ce560574a7adf9100a2R26 and one more that has been added recently: https://github.com/rlxone/Equinox/pull/25/files#diff-f2224169afeee82a6cfd2b0f6698e2d88c65b3a740859fe4a4d5d30985a619e1R21

W1W1-M commented 2 years ago

Hi @rlxone, I've updated accordingly. The branch I originally used for this is still based on main and not on 1.1, so I haven't properly tested changes but should be OK. If you could merge into 1.1 then I could confirm test. Thanks 👍

rlxone commented 2 years ago

@W1W1-M , thank you for thr quick addition! I've tested it with v1.1 - looks good to me.