search

rmjarvis / TreeCorr

Code for efficiently computing 2-point and 3-point correlation functions. For documentation, go to
http://rmjarvis.github.io/TreeCorr/
Other
97 stars 37 forks source link

Changed the permutation of Aperture Radii for the calculation of T1, T2, and T3 #128

Closed llinke1 closed 3 years ago

llinke1 commented 3 years ago

Changes the combinations of the aperture radii used to calculate T1, T2, and T3, so that the obtained <M*MM> is similar to the directly estimated one in the Millennium Simulation.

rmjarvis commented 3 years ago

Thanks Laila! I'll try to write a unit test that can distinguish this version from the old incorrect version, and then release a bug fix with this change. I'll try to get to that next week. Thanks so much for figuring this out!

rmjarvis commented 3 years ago

I figured out a good unit test that detects the old error. Basically just a repeat of what I had for the Map3 calculation tests, but using a complex amplitude, so there was both E and B mode in the shear field. Here's the commit if you'd like to look it over: 7cf905b65866a042

rmjarvis commented 3 years ago

Update: Version 4.2.3 released with this bug fix. Thanks again!