Closed maflcko closed 2 months ago
Thanks for noticing! CC @maxirmx
As far as I remember we need unsigned type. Something like char8_t
as defined in C++20
Frankly speaking, I thought that char8_t was a codification of some options that were provided by default definition of std::char_traits
but the life is not that friendly 👎
I would probably change SEXP simple string to std::vector
I realized that we cannot change signature for sexp_simple_string since libsexpp is deployed as shared library
We will need to provide an specialization of char_traits for octet_t (unsigned char)
With clang-18 and libc++ compile failures are observed: (Tested via the OSS-Fuzz config)
Could it make sense to update the submodule in
src/libsexpp
to provide an specialization of char_traits forunsigned char
, or maybe it would be easier to use one of the pre-defined char_traits?Edit: Context: