search

road86 / bahis-desk

Desktop application for BAHIS2
GNU General Public License v3.0
2 stars 1 forks source link

Devbahis doesn't work on windows after installation after building on windows. #45

Closed mixmixmix closed 1 year ago

mixmixmix commented 1 year ago

Bahis 2.1.0-dev starts fine on windows in console. However starting the installed app produces a blank screen and in developer tools console it says:

Not allowed to load local resource: file:///C:/Program%20Files/bahis/devbahis/resources/app.asar/build/index.html

No such error when running freshly installed version of 2.0.5-dev.

Possibly related to updating electron to 13?

mixmixmix commented 1 year ago

I've reverted to commit for 2.0.5-dev and without changing packages version was able to build a working app. So it isn't necessarily to do with upgrading electron.

mixmixmix commented 1 year ago

Adding to packages.json

  "build": {
    "extends": null,

brings back the error on 2.0.5-dev

mixmixmix commented 1 year ago

I'm resolving this temporarily by removing that line before building the app.

Adding to packages.json

  "build": {
    "extends": null,

brings back the error on 2.0.5-dev

I'm resolving this temporarily by removing that line before building the app. We need to fix it properly though!

ChasNelson1990 commented 1 year ago

This is the correct solution: https://github.com/electron-userland/electron-builder/issues/2030#issuecomment-488725572 However, I would like to move away from react-sripts for exactly this sort of issue, it abstracts stuff away in a very ungeneralisable fashion