search

road86 / bahis-desk

Desktop application for BAHIS2
GNU General Public License v3.0
2 stars 1 forks source link

Add app version to user login API call #47

Closed ChasNelson1990 closed 1 year ago

ChasNelson1990 commented 1 year ago

Problem

It's useful to see in the logs which version of the app a user is using for debugging, update roll outs, etc..

Desired Solution

We could just add an ?version=v1.0.0 tag to the user login request.

Considered Alternatives

No response

Additional Context

No response

ChasNelson1990 commented 1 year ago

@mixmixmix - it would actually be useful to have this on all calls? The nicest fix for road86/bahis-serve#11 would have been to just handle the old version and new version differently. Thoughts?

mixmixmix commented 1 year ago

I agree. As many users will take time to update the app, we have to make sure it is compatible.