robinsving / pf2e-item-revitalizer

Module for handling Item obsolesence after system updates
MIT License
2 stars 0 forks source link

Issue with grid scaler #12

Closed uniwars closed 9 months ago

uniwars commented 9 months ago

Hi, I noticed a weird issue with item revitalizer and grid scaler.

When clicking on the grid scaler button in the left menu it selects item revitalizer instead, making grid scaler unusable.

It seems to come from more then just item revitalizer, but with all other module enabled if I disable it the issue is solved.

What I noticed is that it doesn't work only when item revitalizer is before grid scaler in the left menu listing, if its button is after the grid scaler one then it works fine.

I tried to use find the cutprit but I can't find which module makes item revitalizer go before grid scaler in the menu.

Here is my module list :

Active Modules:

Alternative Rotation v; Ambient Soundbits v; Arms Reach v; Automated Animations v; Background Scaler v; Background Volume v; Battlezoo Bestiary for Pathfinder 2e by Roll For Combat v; Better Roofs v; Canvas Fade In and Out v; Chat Images v; ConversationHUD v; Curtain Animations v; Custom CSS v; DF Active Lights v; DF Chat Enhancements v; DF Curvy Walls v; DFreds Chat Pins v; Dice So Nice! v; Disable Admin v; Drag Anything to Hotbar v; Drag Ruler v; Dungeon Draw v; Filepicker + v; Find the culprit v; Force Client Controls v; Force Client Settings v; Foundry Summons v; FXMaster v; GM Token-Drag Visibility v2 v; GM Vision v; Grid Scaler v; Heartbeat v; Hide GM Rolls v; Image Context v; Jack Kerouac's Animated Spell Effects: Cartoon v; JB2A - Patreon Complete Collection v; Levels v; Levels - Depth Blur v; Levels - Volumetric Templates v; Library - Chat Commander v; Library - CodeMirror vfvtt5; Library - Color Settings v; Library: DF Module Buttons v; Library - Library: Active effect manager v; Library - Library: Scene Packer v; Library - libWrapper v.0; Library - Settings Extender v; Library - socketlib v; Library - Token Action HUD Core v; Limits v; Lock & Key v; Maps - Universal Battlemap Importer v; Mass Edit v; Media Optimizer v; Melvin's Mechanical Masterworks v; Module Management+ v; Monk's Active Tile Triggers v; Monk's Combat Details v; Monk's Combat Marker v; Monk's Enhanced Journal v; Monk's Little Details v; Monk's PF2e Encounter Aftermath v; Monk's Scene Navigation v; Monk's Sound Enhancements v; Monk's TokenBar v; Monk's Wall Enhancement v; Moulinette Core v; Moulinette Image Search (module) v; Moulinette Scenes (module) v; Moulinette Sounds & SoundPad (module) v; Moulinette Tiles (module) v; Move That for You v; Multiface Tiles v; Pathfinder: Harrow v; Pathfinder Token Pack: Bestiaries v; Patrol v; PF2e Action Support Engine v; PF2e Action Support Engine Handlers v; PF2e Action Support Engine Macros v; PF2e Animation Macros v; PF2e Companion Compendia v; PF2e Dailies v; PF2e Drag Ruler Integration v; PF2e Eidolon Helper v; PF2e Exploit Vulnerability v; PF2e Exploration Activities v; PF2E Exploration Effects v; pf2E Extempore Effects v; PF2e Flat Check v; PF2e Giveth v; PF2e Interactive Token Tooltip v; PF2e Item Revitalizer v; PF2e Keybind Menagerie v; PF2e Measure Helper v; Pf2E Modifiers Matter v; PF2E Monster Maker v; PF2e Party Sheet Helper v; PF2e Perception v; PF2e Playtest Data v; PF2e Psychic Amps v; PF2e Reaction Checker v; pF2e See Simple Scale Statistics v; PF2e Spells Summary v; PF2e Stances v; PF2e Staves v; PF2e Summons Helper v; PF2e Target Damage v; PF2E Token Markers v; pf2e Utility Buttons v; PF2e Workbench v; Pings v; Pointers v; Polyglot v; PopOut! v; Pull Players to Scene v; Quick Doors v; Quickdraw v; Quick Encounters v; Quick Grid Align v; Quick Insert - Search Widget v; QuickScale v; ✋ Raise My Hand v; Rave2 for Scene Packer v; Rave3 for Scene Packer v; Ravel for Scene Packer v; Rideable v; routinglib v; Scene Transitions v; Sense Walls v; Sequencer v; Silence Compatibility Warnings v; Smart Doors v; Snowystar Kickstarter Map Pack v; SoundFx Library v; Speaking As v; Stairways (Teleporter) v; Subfolder Indent v; Tagger v; TheRipper93's Module Hub v; Tile Scroll v; Tile Sort v; Token Action HUD Pathfinder 2e v; Token Attacher v; Token Flip v; Token Frames v; Tokenizer v; Token Magic FX v; Token Notes v; Token Says v; Token Variant Art v; Token Z v; UI - PF2e Dorako UI v; UI - Tidy UI - Game Settings v; Visual Novel Choices v; Wall Height v; Warp Gate v; Window Controls v; Z Scatter v; zSync v;

Inactive Modules:

robinsving commented 9 months ago

Hi @uniwars

Which GridScaler module are you using? https://github.com/jbhaywood/scaleGrid/ or the original https://github.com/UberV/scaleGrid/ ?

I think it may be an issue with how we both use the same controle layer name for the getSceneControlButtons Hooks, but I cannot confirm until I know which one you are using.

uniwars commented 9 months ago

https://github.com/jbhaywood/scaleGrid/ this one

robinsving commented 9 months ago

I think that this is an issue with how we both (incorrectly) register our buttons. I will check if I can fix this in the coming days, and then push an issue/PR to the other repo as well

robinsving commented 9 months ago

I have released 1.10.0 now, which should register to a module-specific layer. Please check if this has resolved your issues. Also, please check if there are issues with any other modules you are using. I don't use a lot of modules myself, so those types of interactions are tricky to spot

uniwars commented 9 months ago

the issue is fixed, thanks for the quick update

I'll let yuu know if I dinf anything