search

robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

`Go Back` keyword should wait until page is loaded #109

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by Andreas.EbbertKarroum on 30 Mar 2010

I just ran into the situation that after a "Go Back" I had to insert a sleep, because IE was not ready for the next command (Returned an Error "Erlaubnis verweigert" / "permission denied"). After doing a "Go Back" the SeleniumLibrary should wait until the page is fully loaded.

The patch also includes the new method from issue-107.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 30 Mar 2010

1) Thanks for the report. Using self._wait_for_page_to_load definitely makes sense.

2) It would be better to have a patch with only the relevant changes. I know that's hard to do with svn when you don't have commit rights - you need to revert the other changes - and that's one very good reason why SeleniumLibrary should switch to Mercurial. I submitted issue 110 about it.

3) Instead of using Sleep as a workaround, you should use Wait Until Page Contains or similar keyword.

4) Are there any cases where Go Back shouldn't wait for the page to load? If there are, we can make it configurable, but it should wait by default.

spooning commented 9 years ago

Originally submitted to Google Code by Andreas.EbbertKarroum on 24 Apr 2010

This issue was closed by revision eda8bb516f.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 24 Apr 2010

We use 'Done' status instead of 'Fixed'. Unfortunately there doesn't seem to be option to configure the state used when issues are closed by commit messages.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 27 May 2010

Major improvements warrant a major version