spooning
commented
9 years ago Originally submitted to Google Code by @pekkaklarck on 26 Sep 2010
What does this method actually return? Should the return value be processed by the library somehow or is returning it as-is enough?
Returning the return value of the method in some format is definitely a good idea. In addition to changing the code, the documentation of the keyword needs to be updated (editing the docstring in the source code is enough) and its acceptance tests [1] should also be enhanced. xieyanbo, do you have time and interest to take care of them yourself and attach a patch? We'll obviously help you.
[1] https://code.google.com/p/robotframework-seleniumlibrary/source/browse/test/acceptance/keywords/javascript.txt
Confirm Action use selenium's get_confirmation method, but not return its value. That makes tester can not check confirmation message. Add a return syntax can fix this in javascript.py. Modify confirm_action: {{{ def confirm_action(self): self._selenium.get_confirmation() }}} as: {{{ def confirm_action(self): return self._selenium.get_confirmation() }}} will be OK.