robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

Document that `(Un)Select From List` need to use new `Wait Until Page Loaded` keyword if waiting page load needed #141

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by katiyar.... on 11 Oct 2010

We have "and wait" options for <Select ALL from List> and also for <Select Radio button>,

why not to implement for <Select from List> as well. I need this to be used in my project.

Additional discussion points are available here

http://groups.google.com/group/robotframework-users/browse_thread/thread/469927c679c24ca3?hl=en#

spooning commented 9 years ago

Originally submitted to Google Code by spielman... on 28 Oct 2010

select_from_list takes values as the last argument, so adding wait after values isn't possible. Any idea of a different way that is still elegant? This might work:

def select_from_list_and_wait(self, locator, *values): self.select_from_list(locator, values) self._wait_for_page_to_load()

but it would be a new keyword.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 29 Oct 2010

I don't think adding a new keyword for this rare use case is a good idea. There are two other solutions:

1) Make it so that if the last entry in values is certain string (e.g. 'and wait for page to load') the keyword will wait. Otherwise it will consider all values as values to select and won't wait.

2) Decide not to implement waiting support into this keyword. We could then instead implement Wait For Page To Load keyword (that would probably be a good idea anyway) and tell in the doc of Select From List to use that if waiting is needed.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 29 Oct 2010

I'm starting to think that the option 2) above is better. I already submitted issue 146 about adding Wait For Page To Load keyword.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 11 Nov 2010

We decided not to implement new keyword for this. Instead Wait Until Page Loaded -keyword ( issue 146 ) will be implemented.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 13 Nov 2010

I added a note that the new Wait Until Page Loaded must be used if waiting for page load is needed for both Select From List and Unselect From List.