search

robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

`Page Should (Not) Contain` keywords should support disabling logging page source on failure #147

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by marcin.derucki on 10 Nov 2010

When use keywords "Page should contain" etc, hole page code is saved by robot framework, when use this many times and page code is big than logs files are 100MB and bigger, if so than robot crash when try to parse and save it - this is very serious problem in NSN project for min 100 people. My proposition is to create selector which dissable saving hole page outut, only lines where string that we looking for is found.

Selenium 2.4 Python 2.6 Jython 2.5.1 Linux Red Hat Enterprise 64 bit

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 10 Nov 2010

Page Should Contain already accepts a log level to use when logging the source. We can easily enhance it so that if the level has value NONE, the source is never logged. In the meantime, you can use TRACE or DEBUG level to get rid of the message when tests are executed using the default INFO level.

If there are other keywords that have the same problem, please submit separate issues about them.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 10 Nov 2010

Support for NONE level was added in revision 1a30216085. We also noticed that Page Should Not Contain keyword didn't accept level argument at all and added that too.

spooning commented 9 years ago

Originally submitted to Google Code by marcin.derucki on 10 Nov 2010

Than You very much, that was solved so quickly. I have question about differences between INFO and NONE, does it have impact on Page should (not) contain keyword or some more? second question is when do you plan new release?

spooning commented 9 years ago

Originally submitted to Google Code by marcin.derucki on 10 Nov 2010

Btw, there is dupplicate for this issue: 116

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 10 Nov 2010

If you use NONE as the level argument for these keywords the page source is not logged. If you use DEBUG or TRACE (these work already now with Page Should Contain) the source is not visible by default, but you can see it if you run tests with --loglevel DEBUG or --loglevel TRACE. For more information about the log levels see: http://robotframework.googlecode.com/svn/tags/robotframework-2.5.4/doc/userguide/RobotFrameworkUserGuide.html#log-levels

New SeleniumLibrary release is done pretty soon, probably next week. There are several issues targeted for 2.4.1, but most of the are pretty simple to implement.

Thanks for reminding about issue 116 . We should have actually resolved this issue as its duplicate because it was reported first, but we'll now do the opposite.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 10 Nov 2010

Issue 116 has been merged into this issue.

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 10 Nov 2010

Just realized that other Page Should (Not) Contain keywords (such as Page Should Contain Button) still log the page source. We need to add level argument to all these keywords too.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 11 Nov 2010

Issue 150 has been merged into this issue.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 12 Nov 2010

Added the loglevel argument to other keywords that log page source in r5c6b451e0b3c