All `Wait Until ...` keywords should use Selenium timeout by default

[spooning]

Originally submitted to Google Code by aklisa... on 14 Dec 2010

If no parameter for timeout is set, keyword should use default one.

[spooning]

Originally submitted to Google Code by @pekkaklarck on 14 Dec 2010

Good idea. In addition to Wait Until Page Contains Element, this should be done also with Wait Until Page Contains. Possibly also with Wait For Condition, although it already has its own default for timeout.

This is a simple and safe enhancement and can be done in the next release be it 2.5.1 or 2.6. Patches with documentation and preferably also updated tests are welcome and make sure the feature is added into the next release.

[spooning]

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2011

This issue was updated by revision 3b05b578d6.

Changed all Wait ... keywords so that they use Selenium timeout by default. Also enhanced documentation related to timeouts.

Update issue 164 Status: Review Cc: janne.t.harkonen Now the timeout is converted correctly to milliseconds before passing to Selenium. Timeout is nowadays stored internally in self._timeout as seconds.

[spooning]

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2011

Both this issue and issue 164 were fixed in same timeout overhaul commit. Apparently automatically updating two issues in one commit isn't possible so previous comment looks a bit weird.

I changed also Wait For Condition to use Selenium timeout by default (it used to have its own 5 seconds default value) which is backwards-incompatible. Because the default for Selenium timeout is 5 seconds, this change will affect only users who have set explicitly set Selenium timeout but use Wait For Condition without timeout. These cases should be pretty rare, but this still needs to be documented in the release notes.

Janne, could you review these changes including the enhanced documentation?

[spooning]

Originally submitted to Google Code by @yanne on 27 Jan 2011

Looks good