robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

`Wait Until Page Loaded` requires timeout to be number in milliseconds #164

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2011

This keyword takes an optional timeout which has two problems:

1) It cannot be given in Robot's time syntax (e.g. '2 seconds') 2) It must be given in milliseconds when all other

This keyword was added in 2.5 ( issue 146 )

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2011

Ooops, accidentally submitted this issue while still editing the description.

Changing the timeout to seconds is backwards-incompatible but should be pretty safe because:

spooning commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2011

This issue was fixed by revision 3b05b578d6. I tried updating both this issue and issue 161 with the commit message, but apparently that isn't possible.