robotframework / OldSeleniumLibrary

Deprecated Selenium library for Robot Framework
Apache License 2.0
13 stars 3 forks source link

addCustomRequestHeaders doesn't work #243

Closed spooning closed 9 years ago

spooning commented 9 years ago

Originally submitted to Google Code by chmielsster on 21 Jun 2012

With current version command: selenium.addCustomRequestHeaders doesn't work - it does return success but is ineffective - user specified headers are not added to requests. Selenium server is missing parameter addCustomRequestHeaders=true when initializing new session.

Proposed patch:

--- selenium.py 2012-03-19 19:57:19.000000000 +0100 +++ selenium.py 2012-06-21 16:02:41.666887363 +0200 @⁠@⁠ -186,7 +186,6 @⁠@⁠ start_args = [self.browserStartCommand, self.browserURL, self.extensionJs] if browserConfigurationOptions: start_args.append(browserConfigurationOptions)

spooning commented 9 years ago

Originally submitted to Google Code by chmielsster on 25 Jun 2012

Of course patch above is reversed - simple mistake.

spooning commented 9 years ago

Originally submitted to Google Code by @yanne on 6 Aug 2012

This issue was updated by revision 6ec1a4cb0bf2.