search

robotpy / robotpy-build

(mostly) automated C++ wrapping for Python
BSD 3-Clause "New" or "Revised" License
35 stars 16 forks source link

Replace toml package usage #133

Closed auscompgeek closed 2 years ago

auscompgeek commented 2 years ago

The toml package is unfortunately unmaintained, and implements TOML v0.5.0. The rest of the ecosystem has moved to support TOML v1.0.0.

There are a few TOML v1.0.0 libraries we could use, including:

JawadHalabiMTB commented 2 years ago

Hi @auscompgeek where exactly you use that package ?

auscompgeek commented 2 years ago

@JawadHalabiMTB If you search the code for toml. you should find all usages of it. It's used in several places.

TheTripleV commented 2 years ago

There seems to be a push to get tomli included in stdlib. https://github.com/hukkin/tomli/issues/141

virtuald commented 2 years ago

tomli seems like a good choice

JawadHalabiMTB commented 2 years ago

@auscompgeek 10x man so we can just add tomli package to setup.cfg under [options]->install_requires i guess

auscompgeek commented 2 years ago

Well, the code would also have to be updated to use tomli, but yes that'd be the first step.

JawadHalabiMTB commented 2 years ago

Sure that's my thought as well i mean for sure it should be installed via pip and then just replace all the "import toml" with "import tomli" as wel as the usage and still don't break functionality Ex: toml.load(). I am on it

JawadHalabiMTB commented 2 years ago

Please note that tomli ntends to be minimal so it has no dump/s function which is required by the project so i think we should rethink about the tomli solution

auscompgeek commented 2 years ago

Done in #137.