Add sysidroutine - Githubissues

robotpy / robotpy-commands-v2

Python implementation of the WPILib Command Framework (2020+)

Other

2 stars 14 forks source link

Add sysidroutine #43

Closed LucienMorey closed 4 months ago

LucienMorey commented 4 months ago

todo as far as I can tell:

[x] add to exported classes
[x] port tests
[x] add commenting from original java source code
[x] fix jankiness in code so far ;)

Suggestions on fixes and other tasks I am not even considering would be very helpful

LucienMorey commented 4 months ago

I expect the last mypy failure to happen again but I dont really understand the full extent of the error. The statement is definitely malformed and I think it should be changed to this:

if config.recordState != None:
            self.recordState = config.recordState

This still upsets my type checker though and I am not sure how to handle that. any advice?

auscompgeek commented 4 months ago

This still upsets my type checker though and I am not sure how to handle that. any advice?

Give the member a different name to the method, like how they're not named the same in Java or C++.

LucienMorey commented 4 months ago

should be good to go now @auscompgeek